Adding input validation for the oim and input variable timezone #3740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kratika Patidar <[email protected]>
Signed-off-by: Kratika Patidar <[email protected]>
| fi | ||
|
|
||
|
|
||
| oim_timezone=$(timedatectl | grep "Time zone" | awk '{print $3}') |
Collaborator
There was a problem hiding this comment.
grep time zone is not safe as it can be changed syntax later. can we have any other way to get timezone of oim in any file or any proper command. case sensitive to be handled?
Collaborator
|
Can one of the admins verify this patch? |
|
|
||
| oim_timezone=$(timedatectl | grep "Time zone" | awk '{print $3}') | ||
| if [[ -z "$oim_timezone" ]]; then | ||
| echo -e "${RED}Timezone is not set!${NC}" |
Collaborator
There was a problem hiding this comment.
@priti-parate should we fail here or provide warning and proceed with empty timezone?
Collaborator
|
closing as this this taken further with different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Resolved by this Pull Request
Please be sure to associate your pull request with one or more open issues. Use the word Fixes as well as a hashtag (#) prior to the issue number in order to automatically resolve associated issues (e.g., Fixes #100).
Fixes #
Description of the Solution
Please describe the solution provided and how it resolves the associated issues.
Suggested Reviewers
If you wish to suggest specific reviewers for this solution, please include them in this section. Be sure to include the @ before the GitHub username.