Merge pull request #433 from varemel/main

Fix telegraph fake attached files not clearing between fake requests (ISSUE-432)

src/Facades/Telegraph.php

@@ -103,6 +103,15 @@ public static function fake(array $replies = []): TelegraphFake
         return $fake;
     }
 
+    public static function getFacadeRoot()
+    {
+        $instance = parent::getFacadeRoot();
+        if ($instance instanceof TelegraphFake) {
+            $instance->prepareForNewRequest();
+        }
+        return $instance;
+    }
+
     protected static function getFacadeAccessor(): string
     {
         return 'telegraph';

src/Support/Testing/Fakes/TelegraphFake.php

@@ -15,6 +15,7 @@
 use DefStudio\Telegraph\ScopedPayloads\TelegraphQuizPayload;
 use DefStudio\Telegraph\Telegraph;
 use Illuminate\Support\Arr;
+use Illuminate\Support\Collection;
 use PHPUnit\Framework\Assert;
 
 class TelegraphFake extends Telegraph
@@ -30,6 +31,10 @@ public function __construct(array $replies = [])
         $this->replies = $replies;
     }
 
+    public function prepareForNewRequest(): void {
+        $this->files = new Collection();
+    }
+
     public function editMedia(int $messageId): TelegraphEditMediaFake
     {
         $fake = new TelegraphEditMediaFake($this->replies);

tests/Regression/Issue-432-ClearTelegraphFakeFilesForNewRequestTest.php

@@ -0,0 +1,13 @@
+<?php
+
+use DefStudio\Telegraph\Facades\Telegraph as TelegraphFacade;
+
+test('Clear Telegraph Fake attached files for every new request', function() {
+    TelegraphFacade::fake();
+    $chat = make_chat();
+    $chat->photo(Storage::path('photo.jpg'))->message('test');
+    $telegraphB = $chat->message('123');
+    $filesB = $telegraphB->toArray()['files'];
+
+    expect($filesB)->toBeEmpty();
+});

tests/Unit/Storage/FileStoreDriverTest.php

@@ -3,21 +3,15 @@
 use DefStudio\Telegraph\Concerns\HasStorage;
 use DefStudio\Telegraph\Contracts\Storable;
 use DefStudio\Telegraph\Models\TelegraphChat;
+use DefStudio\Telegraph\Tests\Unit\Storage\TestStorable;
 use Illuminate\Support\Str;
 
 beforeEach(function () {
     Storage::fake();
 });
 
 it('can store and retrieve data', function (string $key, mixed $value) {
-    $class = new class () implements Storable {
-        use HasStorage;
-
-        public function storageKey(): string
-        {
-            return 'foo';
-        }
-    };
+    $class = new TestStorable();
 
     $class->storage('file')->set($key, $value);
 
@@ -43,14 +37,7 @@ public function storageKey(): string
 ]);
 
 it('can store and retrieve a model', function () {
-    $class = new class () implements Storable {
-        use HasStorage;
-
-        public function storageKey(): string
-        {
-            return 'foo';
-        }
-    };
+    $class = new TestStorable();
 
     $model = TelegraphChat::factory()->create();
 
@@ -75,14 +62,7 @@ public function storageKey(): string
 });
 
 it('can store and retrieve a nested model', function () {
-    $class = new class () implements Storable {
-        use HasStorage;
-
-        public function storageKey(): string
-        {
-            return 'foo';
-        }
-    };
+    $class = new TestStorable();
 
     $models = TelegraphChat::factory()->count(4)->create();
 

tests/Unit/Storage/TestStorable.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace DefStudio\Telegraph\Tests\Unit\Storage;
+
+use DefStudio\Telegraph\Concerns\HasStorage;
+use DefStudio\Telegraph\Contracts\Storable;
+
+class TestStorable implements Storable {
+    use HasStorage;
+
+    public function storageKey(): string
+    {
+        return 'foo';
+    }
+}