-
Notifications
You must be signed in to change notification settings - Fork 204
feat: adding delete_by_filter and update_by_filter to WeaviateDocumentStore
#2656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding delete_by_filter and update_by_filter to WeaviateDocumentStore
#2656
Conversation
integrations/weaviate/src/haystack_integrations/document_stores/weaviate/document_store.py
Outdated
Show resolved
Hide resolved
integrations/weaviate/src/haystack_integrations/document_stores/weaviate/document_store.py
Show resolved
Hide resolved
|
@davidsbatista looks good! Just a few minor comments. One other thing that would be nice if straightforward to do is to test the pagination logic in your new methods. So to make sure that if we need to paginate everything still works as expected. Would this be straightforward to do? |
…heck on the async version
|
@sjrl added tests for the pagination as well - there's also other small fixes one can do, not directly related with this PR - I can do them after this one is merged. |
Thanks and sounds good! |
sjrl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Related Issues
update_by_filter()anddelete_by_filter()operations toWeaviateDocumentStore#2335Proposed Changes:
How did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.