Skip to content

Conversation

@davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Jan 6, 2026

Related Issues

Proposed Changes:

  • added delete_by_filter and update_by_filter methods to Weaviate document store
  • Implemented sync and async versions of both methods

How did you test it?

  • added tests for sync (test_document_store.py) and async (test_document_store_async.py) versions, following the same pattern as other document stores (OpenSearch, Elasticsearch)

Checklist

@github-actions github-actions bot added integration:weaviate type:documentation Improvements or additions to documentation labels Jan 6, 2026
@davidsbatista davidsbatista marked this pull request as ready for review January 6, 2026 15:57
@davidsbatista davidsbatista requested a review from a team as a code owner January 6, 2026 15:57
@davidsbatista davidsbatista requested review from sjrl and removed request for a team January 6, 2026 15:57
@sjrl
Copy link
Contributor

sjrl commented Jan 7, 2026

@davidsbatista looks good! Just a few minor comments.

One other thing that would be nice if straightforward to do is to test the pagination logic in your new methods. So to make sure that if we need to paginate everything still works as expected. Would this be straightforward to do?

@davidsbatista
Copy link
Contributor Author

@sjrl added tests for the pagination as well - there's also other small fixes one can do, not directly related with this PR - I can do them after this one is merged.

@davidsbatista davidsbatista requested a review from sjrl January 7, 2026 15:22
@sjrl
Copy link
Contributor

sjrl commented Jan 8, 2026

@sjrl added tests for the pagination as well - there's also other small fixes one can do, not directly related with this PR - I can do them after this one is merged.

Thanks and sounds good!

Copy link
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@davidsbatista davidsbatista merged commit 510b8cb into main Jan 8, 2026
6 checks passed
@davidsbatista davidsbatista deleted the feat/add-update-delete-by-filter-to-Weaviate branch January 8, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:weaviate type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add update_by_filter() and delete_by_filter() operations to WeaviateDocumentStore

3 participants