Skip to content

Conversation

@davidsbatista
Copy link
Contributor

@davidsbatista davidsbatista commented Jan 2, 2026

Related Issues

Proposed Changes:

  • delete_by_filter() and delete_by_filter_async() to delete documents matching filters
  • update_by_filter() and update_by_filter_async() to update metadata for documents matching filters

How did you test it?

  • tests for delete_by_filter (sync and async)
  • tests for update_by_filter (sync and async)

Checklist

@github-actions github-actions bot added integration:chroma type:documentation Improvements or additions to documentation labels Jan 2, 2026
@davidsbatista davidsbatista changed the title adding new operations + tests feat: adding delete_by_filter() and update_by_filter() to ChromaDocumentStore Jan 2, 2026
@davidsbatista davidsbatista changed the title feat: adding delete_by_filter() and update_by_filter() to ChromaDocumentStore feat: adding delete_by_filter() and update_by_filter() to ChromaDocumentStore Jan 2, 2026
@davidsbatista davidsbatista marked this pull request as ready for review January 2, 2026 15:34
@davidsbatista davidsbatista requested a review from a team as a code owner January 2, 2026 15:34
@davidsbatista davidsbatista requested review from mpangrazzi and removed request for a team January 2, 2026 15:34
Copy link
Contributor

@mpangrazzi mpangrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks already good! I've left a few comments.

Copy link
Contributor

@mpangrazzi mpangrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@davidsbatista davidsbatista merged commit feb4888 into main Jan 7, 2026
10 checks passed
@davidsbatista davidsbatista deleted the feat/add-update-delete-by-filter-Chroma branch January 7, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration:chroma type:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add update_by_filter() and delete_by_filter() operations to ChromaDocumentStore

3 participants