Skip to content

fix(google_ai): close aiohttp session to prevent ResourceWarning #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raymondWai wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(google_ai): close aiohttp session to prevent ResourceWarning #2629

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07c5aad
fix(google_ai): close aiohttp session to prevent ResourceWarning
raymondWai Dec 27, 2025
6fcb789
fix(google_ai): close aiohttp session in destrructor instead of run_a…
raymondWai Jan 3, 2026
0aed5b0
fix(google_ai): fix the code format issue
raymondWai Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 25 additions & 18 deletions ...genai/src/haystack_integrations/components/generators/google_genai/chat/chat_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import json
from collections.abc import AsyncIterator, Iterator
from datetime import datetime, timezone
from types import TracebackType
from typing import Any, Literal, Optional

from google.genai import types
Expand Down Expand Up @@ -507,6 +508,14 @@ def __init__(
self._streaming_callback = streaming_callback
self._tools = tools

def __del__(self):
self._client.close()

def __exit__(
self, exc_type: Optional[Exception], exc_value: Optional[Exception], traceback: Optional[TracebackType]
) -> None:
self._client.close()

def to_dict(self) -> dict[str, Any]:
"""
Serializes the component to a dictionary.
Expand Down Expand Up @@ -880,15 +889,14 @@ def run(
config=config,
)
return self._handle_streaming_response(response_stream, streaming_callback)
else:
# Use non-streaming
response = self._client.models.generate_content(
model=self._model,
contents=contents,
config=config,
)
reply = _convert_google_genai_response_to_chatmessage(response, self._model)
return {"replies": [reply]}
# Use non-streaming
response = self._client.models.generate_content(
model=self._model,
contents=contents,
config=config,
)
reply = _convert_google_genai_response_to_chatmessage(response, self._model)
return {"replies": [reply]}

except Exception as e:
# Check if the error is related to thinking configuration
Expand Down Expand Up @@ -989,15 +997,14 @@ async def run_async(
config=config,
)
return await self._handle_streaming_response_async(response_stream, streaming_callback)
else:
# Use non-streaming
response = await self._client.aio.models.generate_content(
model=self._model,
contents=contents,
config=config,
)
reply = _convert_google_genai_response_to_chatmessage(response, self._model)
return {"replies": [reply]}
# Use non-streaming
response = await self._client.aio.models.generate_content(
model=self._model,
contents=contents,
config=config,
)
reply = _convert_google_genai_response_to_chatmessage(response, self._model)
return {"replies": [reply]}

except Exception as e:
# Check if the error is related to thinking configuration
Expand Down