perf(store): Cache output stride parameters in registers to reduce global loads #6
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the
store()
function in the FlashMLA kernel by caching frequently used output stride parameters (i.e.,o_batch_stride
,o_row_stride
, ando_head_stride
) into local registers. By using the__ldg
intrinsic to read these values once per thread, we reduce repetitive global memory accesses and potentially lower memory latency. This improvement should help improve kernel performance without affecting functionality.Key Changes
params.o_batch_stride
,params.o_row_stride
, andparams.o_head_stride
in thestore()
function.__ldg
intrinsic to hint to the compiler that these values are read-only.Impact
This change is a targeted performance optimization that minimizes redundant memory loads from global memory, improving efficiency without altering correctness.