Skip to content

Conversation

@ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Oct 12, 2025

This brings support for NGC PyTorch containers and removes cuda11 since it doesn't seem to be compatible anymore

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
@ko3n1g
Copy link
Collaborator Author

ko3n1g commented Oct 12, 2025

Here's a passing run: https://github.com/ko3n1g/DeepGEMM/actions/runs/18443482987

@ko3n1g
Copy link
Collaborator Author

ko3n1g commented Oct 12, 2025

After merging this one, can we create and push a new tag @LyricZhao ?

@LyricZhao
Copy link
Collaborator

After merging this one, can we create and push a new tag @LyricZhao ?

Sure! Can you bring Python 3.8 back?

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
@ko3n1g
Copy link
Collaborator Author

ko3n1g commented Oct 13, 2025

Sure! Can you bring Python 3.8 back?

which cuda and torch version do you expect/ want to support with py3.8?

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
@LyricZhao
Copy link
Collaborator

How about CUDA 12.3 + PyTorch 2.1.0?

@ko3n1g
Copy link
Collaborator Author

ko3n1g commented Oct 13, 2025

Okay, looks like we've got it now. Here's the job that also builds a wheel for Py3.8/Cu12.3,PyT2.1.0: https://github.com/ko3n1g/DeepGEMM/actions/runs/18457600231/job/52581827327

Since support for Py3.8 is quite limited I didn't include a vast grid but just this singular configuration

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
@ko3n1g
Copy link
Collaborator Author

ko3n1g commented Oct 13, 2025

I think we need to use cuda11.8 instead: https://github.com/pytorch/pytorch/blob/main/RELEASE.md#release-compatibility-matrix

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
@ko3n1g
Copy link
Collaborator Author

ko3n1g commented Oct 13, 2025

@LyricZhao Finally got it working with cuda12.1: https://github.com/ko3n1g/DeepGEMM/actions/runs/18465627532/job/52608861167

@ko3n1g ko3n1g requested a review from LyricZhao October 13, 2025 12:47
Signed-off-by: oliver könig <[email protected]>
@LyricZhao
Copy link
Collaborator

LGTM, ready for merge now?

@ko3n1g
Copy link
Collaborator Author

ko3n1g commented Oct 14, 2025

Yep!

@LyricZhao LyricZhao merged commit 93b3c28 into deepseek-ai:main Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants