-
Notifications
You must be signed in to change notification settings - Fork 738
ci: Fixes for pre-built wheels #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
|
Here's a passing run: https://github.com/ko3n1g/DeepGEMM/actions/runs/18443482987 |
|
After merging this one, can we create and push a new tag @LyricZhao ? |
Sure! Can you bring Python 3.8 back? |
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
which cuda and torch version do you expect/ want to support with py3.8? |
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
|
How about CUDA 12.3 + PyTorch 2.1.0? |
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
|
Okay, looks like we've got it now. Here's the job that also builds a wheel for Py3.8/Cu12.3,PyT2.1.0: https://github.com/ko3n1g/DeepGEMM/actions/runs/18457600231/job/52581827327 Since support for Py3.8 is quite limited I didn't include a vast grid but just this singular configuration |
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
|
I think we need to use cuda11.8 instead: https://github.com/pytorch/pytorch/blob/main/RELEASE.md#release-compatibility-matrix |
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
|
@LyricZhao Finally got it working with cuda12.1: https://github.com/ko3n1g/DeepGEMM/actions/runs/18465627532/job/52608861167 |
Signed-off-by: oliver könig <[email protected]>
|
LGTM, ready for merge now? |
|
Yep! |
This brings support for NGC PyTorch containers and removes cuda11 since it doesn't seem to be compatible anymore