Skip to content

chunk engine group_id clean up #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

chunk engine group_id clean up #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/storage/chunk_engine/src/types/group_id.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ impl GroupId {
// 32bit chunk size + 24bit group + 8bit cluster
const SHIFT: u32 = 8;
pub const COUNT: u32 = (1 << Self::SHIFT);
pub const CLUSTER_MASK: u64 = (Self::COUNT - 1) as u64;
pub const GROUP_MASK: u64 = ((1u64 << 24) - 1) << Self::SHIFT;

pub const fn new(chunk_size: Size, cluster: u8, group: u32) -> Self {
Self(chunk_size.0 << 32 | (group << Self::SHIFT | cluster as u32) as u64)
Expand All @@ -31,8 +33,7 @@ impl GroupId {
}

pub fn offset(&self) -> Size {
const MARKS: u64 = !(GroupId::COUNT - 1) as u64;
self.chunk_size() * (self.0 & MARKS)
self.chunk_size() * (self.0 & Self::GROUP_MASK)
}

pub fn size(&self) -> Size {
Expand Down
3 changes: 1 addition & 2 deletions src/storage/chunk_engine/src/types/position.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ impl Position {
}

pub fn group_id(&self) -> GroupId {
const MARKS: u64 = (GroupId::COUNT - 1) as u64;
const CLEAN: u64 = !(MARKS | MARKS << 32);
const CLEAN: u64 = !(GroupId::CLUSTER_MASK | GroupId::CLUSTER_MASK << 32);
GroupId::from(self.0 & CLEAN | self.cluster() as u64)
}

Expand Down