Skip to content

move nextAvail back as much as possible #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

move nextAvail back as much as possible #199

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c712ce1
move back AMAP
symious Mar 20, 2025
d689e10
change indent
symious Mar 20, 2025
55c7f3f
change to prefix operator
symious Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/common/utils/AtomicSharedPtrTable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@ struct AvailSlots {

std::lock_guard lock(mutex);
if (idx == nextAvail - 1) {
while (free.find(--nextAvail) != free.end()) {
// move back next avail as much as possible
;
nextAvail--;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer the prefix operator here when the result is not needed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. But for a tiny style issue, I think the fix is good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@echaozh Thank you for the review, updated the PR, PTAL.

while (free.find(nextAvail - 1) != free.end()) {
// move back next avail as much as possible
free.erase(--nextAvail);
}
} else {
free.insert(idx);
Expand Down