-
Notifications
You must be signed in to change notification settings - Fork 4
chore(deps): update definitelytyped #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughBumps TypeScript declaration package versions in package.json: Pre-merge checks✅ Passed checks (3 passed)
Comment |
|
e7995d7 to
b6fd35b
Compare
b6fd35b to
136521d
Compare
136521d to
c44d7c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
324357d to
b43aa9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
src/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: CI
package.json
[error] 1-1: Command failed with exit code 1: npm ci --prefer-offline --no-audit
b71a11c to
2b76688
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
src/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (1)
package.json (1)
2276-2276: Clarify @types/temp vs runtime tmp package.Line 2276 references
@types/temp@^0.9.0, but the runtime dependency istmp@^0.2.4(line 2218). Verify these refer to the same package or clarify the intent.
3ba1ac3 to
68e1475
Compare
6e2b641 to
81e1715
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
81e1715 to
a875b41
Compare
a875b41 to
7997517
Compare
9e35723 to
b3d3f13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
b3d3f13 to
0505883
Compare
0505883 to
36dc8cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
36dc8cd to
f08d316
Compare
f08d316 to
739f08b
Compare
739f08b to
d886ba0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/test/vscode-notebook-perf/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
| "@types/node": "^22.15.1", | ||
| "@types/node-fetch": "^2.6.12", | ||
| "@types/pdfkit": "^0.11.0", | ||
| "@types/pdfkit": "^0.17.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify package-lock.json has been regenerated and committed—past reviews flagged critical lockfile mismatch.
The four @types package updates are correct, but prior reviews identified and flagged a critical blocker: package-lock.json was out of sync with package.json (e.g., @types/react-json-tree declared as ^0.13.0 in package.json but pinned to 0.6.11 in the lockfile), causing npm ci to fail. Past comments claim this was addressed, yet the PR remains in draft.
Confirm that package-lock.json has been regenerated to include all four updated packages and committed alongside this change. Run npm ci locally to verify it succeeds.
Also applies to: 2590-2590, 2597-2597, 2601-2601
🏁 Script executed:
#!/bin/bash
# Verify package-lock.json contains the four updated @types packages with matching versions
if [ ! -f package-lock.json ]; then
echo "ERROR: package-lock.json not found"
exit 1
fi
echo "=== Checking lockfile for four updated @types packages ==="
jq -r '.packages[] | select(.name | test("@types/(pdfkit|react-json-tree|stack-trace|temp)")) | "\(.name): \(.version)"' package-lock.json 2>/dev/null | sort
echo ""
echo "=== Corresponding package.json entries ==="
jq -r '.devDependencies | to_entries[] | select(.key | test("@types/(pdfkit|react-json-tree|stack-trace|temp)")) | "\(.key): \(.value)"' package.json 2>/dev/null | sort
echo ""
echo "=== Attempting npm ci (dry-run) ==="
npm ci --dry-run 2>&1 | head -20 || echo "npm ci check failed"Length of output: 1053
Regenerate package-lock.json—four @types packages missing from lockfile.
Verification confirms the critical blocker from prior reviews: all four @types packages are declared in package.json but do not exist in package-lock.json. This will cause npm ci to fail.
Run npm install locally to regenerate package-lock.json with all four packages, then commit the updated lockfile alongside this change.
🤖 Prompt for AI Agents
In package.json around line 2586, four @types packages declared (including
"@types/pdfkit") are missing from package-lock.json which will break npm ci; run
npm install locally to regenerate package-lock.json so those four @types entries
are added, verify the lockfile includes all @types packages from package.json,
then commit and push the updated package-lock.json alongside this change.
This PR contains the following updates:
4.3.6->4.3.202.0.1->2.0.37.1.6->7.1.82.8.12->2.8.194.1.7->4.1.120.7.0->0.7.24.0.0->4.0.31.0.2->1.0.45.0.37->5.0.385.0.3->5.0.75.13.4->5.13.104.14.181->4.17.2018.19.31->18.19.13022.15.31->22.19.12.6.12->2.6.13^0.11.0->^0.17.00.4.0->0.4.316.9.14->16.9.25^0.6.8->^0.13.07.1.23->7.1.349.21.20->9.22.33.0.9->3.0.1310.0.15->10.0.200.0.29->0.0.332.0.1->2.0.40.1.0->0.1.31.0.1->1.0.4^0.8.32->^0.9.00.2.3->0.2.61.4.8->1.4.111.88.0->1.106.01.60.0->1.72.4Configuration
📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.