Skip to content

Conversation

@chayim
Copy link

@chayim chayim commented May 15, 2025

Thank you for the awesome project! As part of my use, I noticed a tonne of print statements, whenever I run my tests. This is getting in the way of debugging. As a result, I integrated a logger. For every (non-thirdparty) statement present, I replaced print with log. When the error text indicated a level (eg. warning, error), I used that log level.

When no level was specified I defaulted to DEBUG, which now, will not print.

Should someone want debug, they merely have to set the environment variable DEBUG to any value.

Thanks again for a great project, I hope this is useful to someone else, given #2481

@Jimmy-ajia
Copy link

Jimmy-ajia commented May 15, 2025 via email

@GreatNewWorldDev
Copy link

@nttstar Hi, this PR seems to improve the current logging approach by using a dedicated logger with a INFO default log level which will allow to filter out repetitive, debug logs which usually just clutter the console while allowing to specify an environment variable to see debug logs when needed for debugging. So it would be great if you have time to review this small PR, see if can be merged or needs adjustments. Thanks for your attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants