fix: Input Tables cannot paste more rows than number of visible rows (DH-18723) #2371
+72
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Feb 19, 2025
•
mofojed
commented
- cherry-picked from fix: Editing issues when key columns are not first columns #2053 and fix: Input Tables cannot paste more rows than number of visible rows #2152
- Resolves Input Tables cannot Paste More than the Number of Visible Rows #2089
- I published an alpha package and tested it against dev-jackson2 with the test steps from DH-18184
…#2053) Resolves deephaven#2036 **Changes Implemented:** - Changed check for key columns within range **to no longer check** whether the _start of the range is > # of key columns_ and _end of range is > # of key columns_ , **but rather**, iterate through and check _if any of the columns are key columns_ - The check priorly was making it so that the key columns are always the first columns, which was causing issues with editing columns if they were not
vbabich
approved these changes
Feb 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.