Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Unit test summary #211

Merged
merged 10 commits into from
Jan 29, 2025
Merged

build: Unit test summary #211

merged 10 commits into from
Jan 29, 2025
+20 −8

Conversation

bmingles
Copy link
Collaborator

@bmingles bmingles commented Jan 27, 2025 •
edited
Loading

DH-18524: Fixed unit test report path that was breaking GH action

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
660000005:16:26
 A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
should default to the correct settingspassed ✅2090
should return custom settings: Empty configspassed ✅295
should return custom settings: Populated configspassed ✅110
should be able to load VSCodepassed ✅930
should only be visible when a supported file type is active: test.groovypassed ✅3072
should only be visible when a supported file type is active: test.pypassed ✅1277
 A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

Unit Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
1191190000000:00:00
 A ctrf plugin

Detailed Test Results

NameStatusmsFlaky 🍂
src/services/ConfigService.spec.ts: getCoreServers > should return core servers: Empty configpassed ✅2
src/services/ConfigService.spec.ts: getCoreServers > should return core servers: String configpassed ✅1
src/services/ConfigService.spec.ts: getCoreServers > should return core servers: No labelpassed ✅0
src/services/ConfigService.spec.ts: getCoreServers > should return core servers: Full configpassed ✅1
src/services/ConfigService.spec.ts: getEnterpriseServers > should return enterprise servers: Empty configpassed ✅0
src/services/ConfigService.spec.ts: getEnterpriseServers > should return enterprise servers: String configpassed ✅0
src/services/PollingService.spec.ts: pollUntilTrue > should resolve when poll function returns truepassed ✅8
src/services/PollingService.spec.ts: pollUntilTrue > should cancel polling if timeout exceededpassed ✅2
src/services/PollingService.spec.ts: pollUntilTrue > should cancel polling if cancel explicitly calledpassed ✅1
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > should key data by value equalitypassed ✅3
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > entries > should provide value equality entriespassed ✅2
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > keys > should provide value equality keyspassed ✅1
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > forEach > should pass value equality keys to callback: undefinedpassed ✅3
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > forEach > should pass value equality keys to callback: {}passed ✅1
src/services/SerializedKeyMap.spec.ts: SerializedKeyMap > values > should provide valuespassed ✅0
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: {}passed ✅1
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: testpassed ✅0
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: 999passed ✅1
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: truepassed ✅0
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: falsepassed ✅0
src/util/assertUtil.spec.ts: assertDefined > should not throw if value is defined: 2025-01-28T17:34:15.066Zpassed ✅0
src/util/assertUtil.spec.ts: assertDefined > should throw an error for null or undefined values: nullpassed ✅1
src/util/assertUtil.spec.ts: assertDefined > should throw an error for null or undefined values: undefinedpassed ✅0
src/util/promiseUtils.spec.ts: waitFor > should return a Promise that resolves after a given timeoutpassed ✅5
src/util/promiseUtils.spec.ts: withResolvers > should return a promise that resolves when resolve function is calledpassed ✅2
src/util/promiseUtils.spec.ts: withResolvers > should return a promise that rejects when reject function is calledpassed ✅1
src/util/serverUtils.spec.ts: getInitialServerStates > should derive server states from configpassed ✅4
src/util/serverUtils.spec.ts: getPipServerUrl > should return a localhost url based on given portpassed ✅1
src/util/serverUtils.spec.ts: parsePort > should parse port from stringpassed ✅0
src/util/serverUtils.spec.ts: parsePort > should throw error when port is not a numberpassed ✅0
src/util/tmpUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: true, undefinedpassed ✅4
src/util/tmpUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: true, subDirectorypassed ✅1
src/util/tmpUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: false, undefinedpassed ✅1
src/util/tmpUtils.spec.ts: getTempDir > should create temp directory if it does not already exist: false, subDirectorypassed ✅0
src/util/tmpUtils.spec.ts: getTempDir > should remove directory if recreate is true: true, undefined, /home/runner/work/vscode-deephaven/vscode-deephaven/src/common/tmppassed ✅1
src/util/tmpUtils.spec.ts: getTempDir > should remove directory if recreate is true: true, subDirectory, /home/runner/work/vscode-deephaven/vscode-deephaven/src/common/tmp/subDirectorypassed ✅0
src/util/tmpUtils.spec.ts: getTempDir > should remove directory if recreate is true: false, undefined, /home/runner/work/vscode-deephaven/vscode-deephaven/src/common/tmppassed ✅1
src/util/tmpUtils.spec.ts: getTempDir > should remove directory if recreate is true: false, subDirectory, /home/runner/work/vscode-deephaven/vscode-deephaven/src/common/tmp/subDirectorypassed ✅1
src/util/treeViewUtils.spec.ts: getPanelConnectionTreeItem > should return panel connection tree item: isConnected:true, isInitialized:truepassed ✅4
src/util/treeViewUtils.spec.ts: getPanelConnectionTreeItem > should return panel connection tree item: isConnected:true, isInitialized:falsepassed ✅0
src/util/treeViewUtils.spec.ts: getPanelConnectionTreeItem > should return panel connection tree item: isConnected:false, isInitialized:truepassed ✅0
src/util/treeViewUtils.spec.ts: getPanelConnectionTreeItem > should return panel connection tree item: isConnected:false, isInitialized:falsepassed ✅0
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:deephaven.plot.express.DeephavenFigurepassed ✅1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:deephaven.ui.Elementpassed ✅0
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:Figurepassed ✅1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:HierarchicalTablepassed ✅0
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:OtherWidgetpassed ✅1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:pandas.DataFramepassed ✅1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:PartitionedTablepassed ✅0
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:Tablepassed ✅1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:TableMappassed ✅0
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:Treemappassed ✅1
src/util/treeViewUtils.spec.ts: getPanelVariableTreeItem > should return panel variable tree item: type:TreeTablepassed ✅0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=true, isManaged=true, isRunning=truepassed ✅1
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=true, isManaged=true, isRunning=falsepassed ✅0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=true, isManaged=false, isRunning=truepassed ✅0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=true, isManaged=false, isRunning=falsepassed ✅1
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=false, isManaged=true, isRunning=truepassed ✅0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=false, isManaged=true, isRunning=falsepassed ✅0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=false, isManaged=false, isRunning=truepassed ✅0
src/util/treeViewUtils.spec.ts: getServerContextValue > should return contextValue based on server state: isConnected=false, isManaged=false, isRunning=falsepassed ✅0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=0, isManaged=true, label=some labelpassed ✅1
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=0, isManaged=true, label=undefinedpassed ✅0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=0, isManaged=false, label=some labelpassed ✅0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=0, isManaged=false, label=undefinedpassed ✅0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=1, isManaged=true, label=some labelpassed ✅0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=1, isManaged=true, label=undefinedpassed ✅1
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=1, isManaged=false, label=some labelpassed ✅0
src/util/treeViewUtils.spec.ts: getServerDescription > should return server description based on parameters: connectionCount=1, isManaged=false, label=undefinedpassed ✅0
src/util/treeViewUtils.spec.ts: getServerGroupContextValue > should return context value when servers can be managed: group=Managed, canStartServer=truepassed ✅0
src/util/treeViewUtils.spec.ts: getServerGroupContextValue > should return context value when servers can be managed: group=Managed, canStartServer=falsepassed ✅0
src/util/treeViewUtils.spec.ts: getServerGroupContextValue > should return context value when servers can be managed: group=Running, canStartServer=truepassed ✅1
src/util/treeViewUtils.spec.ts: getServerGroupContextValue > should return context value when servers can be managed: group=Running, canStartServer=falsepassed ✅0
src/util/treeViewUtils.spec.ts: getServerGroupTreeItem > should return server group tree item: group=Managed, canStartServer=truepassed ✅0
src/util/treeViewUtils.spec.ts: getServerGroupTreeItem > should return server group tree item: group=Managed, canStartServer=falsepassed ✅0
src/util/treeViewUtils.spec.ts: getServerGroupTreeItem > should return server group tree item: group=Running, canStartServer=truepassed ✅0
src/util/treeViewUtils.spec.ts: getServerGroupTreeItem > should return server group tree item: group=Running, canStartServer=falsepassed ✅1
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=true, isManaged=true, isRunning=truepassed ✅0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=true, isManaged=true, isRunning=falsepassed ✅0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=true, isManaged=false, isRunning=truepassed ✅0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=true, isManaged=false, isRunning=falsepassed ✅0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=false, isManaged=true, isRunning=truepassed ✅1
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=false, isManaged=true, isRunning=falsepassed ✅0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=false, isManaged=false, isRunning=truepassed ✅0
src/util/treeViewUtils.spec.ts: getServerIconID > should return icon id based on server state: isConnected=false, isManaged=false, isRunning=falsepassed ✅0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=true, isManaged=true, isRunning=truepassed ✅0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=true, isManaged=true, isRunning=falsepassed ✅1
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=true, isManaged=false, isRunning=truepassed ✅0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=true, isManaged=false, isRunning=falsepassed ✅0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=false, isManaged=true, isRunning=truepassed ✅0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=false, isManaged=true, isRunning=falsepassed ✅0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=false, isManaged=false, isRunning=truepassed ✅1
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHC, isConnected=false, isManaged=false, isRunning=falsepassed ✅0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=true, isManaged=true, isRunning=truepassed ✅0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=true, isManaged=true, isRunning=falsepassed ✅1
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=true, isManaged=false, isRunning=truepassed ✅0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=true, isManaged=false, isRunning=falsepassed ✅0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=false, isManaged=true, isRunning=truepassed ✅1
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=false, isManaged=true, isRunning=falsepassed ✅0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=false, isManaged=false, isRunning=truepassed ✅0
src/util/treeViewUtils.spec.ts: getServerTreeItem > should return server tree item: type=DHE, isConnected=false, isManaged=false, isRunning=falsepassed ✅1
src/util/treeViewUtils.spec.ts: getVariableIconPath > should return icon path for variableTypepassed ✅0
src/util/treeViewUtils.spec.ts: groupServers > should group servers by statepassed ✅1
src/util/uiUtils.spec.ts: createConnectionOption > should return connection option: 'DHC', { label: 'python', url: URL{} }passed ✅3
src/util/uiUtils.spec.ts: createConnectionOption > should return connection option: 'DHC', { label: 'groovy', url: URL{} }passed ✅1
src/util/uiUtils.spec.ts: createConnectionQuickPickOptions > should return quick pick options: editorActiveConnectionUrl=No activepassed ✅13
src/util/uiUtils.spec.ts: createConnectionQuickPickOptions > should return quick pick options: editorActiveConnectionUrl=Active Apassed ✅1
src/util/uiUtils.spec.ts: createConnectionQuickPickOptions > should throw if no servers or connectionspassed ✅1
src/util/uiUtils.spec.ts: createConnectText > should return text and tooltip: 'connecting'passed ✅1
src/util/uiUtils.spec.ts: createConnectText > should return text and tooltip: 'connected'passed ✅0
src/util/uiUtils.spec.ts: createConnectText > should return text and tooltip: 'disconnected'passed ✅0
src/util/uiUtils.spec.ts: updateConnectionStatusBarItem > should update connection status bar item: 'connecting'passed ✅0
src/util/uiUtils.spec.ts: updateConnectionStatusBarItem > should update connection status bar item: 'connected'passed ✅0
src/util/uiUtils.spec.ts: updateConnectionStatusBarItem > should update connection status bar item: 'disconnected'passed ✅1
src/util/uiUtils.spec.ts: createSeparatorPickItem > should create a separator quick pick item with labelpassed ✅1
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: http://localhost:4000, localhost_4000passed ✅1
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: https://localhost:5000, localhost_5000passed ✅0
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: http://www.acme.com:6000, www_acme_com_6000passed ✅1
src/util/urlUtils.spec.ts: urlUtils > should convert url to host_port string: https://www.acme.com:7000, www_acme_com_7000passed ✅0
 A ctrf plugin

Failed Test Summary

No failed tests ✨

Flaky Test Summary

No flaky tests detected. ✨

@bmingles bmingles marked this pull request as ready for review January 28, 2025 00:17
@bmingles bmingles requested a review from mofojed January 28, 2025 00:18
mofojed
mofojed requested changes Jan 28, 2025
View reviewed changes
package.json Outdated
@@ -43,7 +43,7 @@
"test:ci": "npm run compile && npm run test:lint && npm run test:unit",
"test:e2e": "npm run compile && cd e2e && wdio run ./wdio.conf.ts",
"test:lint": "eslint . --ext ts",
"test:unit": "vitest --reporter=default --reporter=junit --outputFile=./test-reports/vitest.junit.xml",
"test:unit": "vitest --reporter=default --reporter=junit --outputFile=../test-reports/vitest.junit.xml",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of confusing because we have root: 'src' in the config - I would have expected this to be relative to package.json, but it's relative to the root defined in the config.

I think instead in the config we shouldn't be changing root, and we should instead be specifying dir: https://vitest.dev/config/#dir
Or just include.

@bmingles bmingles requested a review from mofojed January 28, 2025 17:49
mofojed
mofojed previously approved these changes Jan 29, 2025
View reviewed changes
vitest.config.mts Outdated Show resolved Hide resolved
@bmingles @mofojed
Update vitest.config.mts
ed7323b 
Co-authored-by: Mike Bender <[email protected]>
@bmingles bmingles requested a review from mofojed January 29, 2025 15:40
@bmingles bmingles merged commit 2c06df8 into main Jan 29, 2025
3 checks passed
@bmingles bmingles deleted the spike-fix-pr-ci branch January 29, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmingles @mofojed