feat: ui.meter #1032
Merged
feat: ui.meter #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
previously approved these changes
Nov 27, 2024
| key: str | None = None, | ||
| ) -> Element: | ||
| """ | ||
| Meters visually represent a quantity or achievement, with their progress driven by user actions instead of system actions. |
There was a problem hiding this comment.
I know this is almost verbatim what React Spectrum says, but it seems odd. What do they mean by user actions instead of system actions? The first example they have is for "Storage Space".
It's fine to leave it, but I wouldn't be mad if you re-worded it to make sense (ditto in the docs). Something like:
Meters visually represent a quantity or achievement, displaying progress on a bar with a label.
There was a problem hiding this comment.
Agreed I wasn't sure what system actions meant either. Wanted to see if it made sense to @dsmmcken and @margaretkennedy . For now I will change to your suggestion though
mofojed
previously approved these changes
Nov 29, 2024
margaretkennedy
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #939
IMPORTANT: Variant prop is not working. Need to upgrade to newer version of spectrum. Covered in this web-client-ui PR