fix: JS ChartData should write updates to the correct row (#6638) #6643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6638) The provided mapping function was also not applied to modified rows, also fixed in this patch. Also fixed an error in typescript types/docs for the ChartData.update() parameter. Regression introduced by deephaven#6076. Fixes DH-18632 Backport deephaven#6638
mattrunyon
previously approved these changes
Feb 12, 2025
|
Marked as draft to resolve some test timeouts. |
Effectively increases the timeout for each command run - multiline commands must be explicitly declared as such. Follow-up DH-18632
mattrunyon
approved these changes
Feb 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided mapping function was also not applied to modified rows, also fixed in this patch.
Also fixed an error in typescript types/docs for the ChartData.update() parameter.
Regression introduced by #6076.
Fixes DH-18632
Backport #6638