feat(cpp-client): Honor Arrow TimeUnit when converting Timestamp and Time64 to ColumnSource #6609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosak
added
NoDocumentationNeeded
NoReleaseNotesNeeded
…Time64 to ColumnSource
kosak
force-pushed
the
kosak_time-units
branch
from
88f6267 to
f40b628
Compare
nbauernfeind
approved these changes
Feb 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has adds two tests but leaves one disabled. The disabled one will fail on the main branch; that is why it is disabled.
To run all the tests, execute this command.
Then, if you rebase this branch onto your
nate/nightly/barrage_typesbranch, you can re-enable the disabled test by editing the filecpp-client/deephaven/tests/src/time_unit_test.ccand removing the tag[.hidden]. Currently that tag is at line 75.You should then be able to run all the unit tests with the same gradlew command above and they should all pass.