fix: Close Jetty h2 streams with RST_STREAM and no error code #6441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deephaven#6401)" This reverts commit 6ada0cb.
deephaven#6401)" This reverts commit 4945b87.
niloc132
added
jsapi
grpc
NoDocumentationNeeded
python-client
ReleaseNotesNeeded
devinrsmith
previously approved these changes
Nov 26, 2024
|
Converting to draft, the original fix didnt actually reapply the original fix, git seemed to have decided it wasnt needed... Reapplying the real fix seems to be adding regular stack traces to the server log when the docker healthcheck runs, will file a bug shortly to track. |
…eephaven#6478) Changes from deephaven#6420 were supposed to be reverted in deephaven#6424, but apparently git interpreted the branch's relationship with main differently than I did. This patch reapplies deephaven#6401, with an additional change to avoid noisy stack traces from grpc clients that set `grpc-timeout`. At this time, Deephaven doesn't handle timeouts nor do any default clients set timeouts, so the impact here should be minimal. Fixes deephaven#5996 See deephaven#6400
cpwright
approved these changes
Dec 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Jetty-specific workaround to avoid irritating the Python gRPC client into failing calls that had already half-closed successfully.
Since we're now using ServletOutputStream.close() in place of AsyncContext.complete(), we need to apply the same wrapping for trailers to close() - that is, when the stream is clsoed, we can't rely on the servlet container sending our trailers because grpc-web trailers are actually a DATA frame which must be explicitly written.
See #6400
Fixes #5996
Reapplies #6401
Backport #6424
Backport #6478