fix: Added support to read iceberg tables partitioned by date #6430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
NoDocumentationNeeded
ReleaseNotesNeeded
malhotrashivam
changed the title
devinrsmith
reviewed
Nov 25, 2024
Comment on lines
+96
to
+97
| colValue = IdentityPartitionConverters.convertConstant( | ||
| partitionData.getType(colData.index), valueFromPartitionData); |
There was a problem hiding this comment.
Is this okay to universally apply? Should we only do it when the partition spec specifies identity? https://iceberg.apache.org/spec/#partition-transforms
There was a problem hiding this comment.
Added a check to ensure identity transform and created this issue #6438.
We would need to test properly for non-identity transform.
devinrsmith
approved these changes
Nov 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6419