fix: Go and JS clients should not require v1+v2 auth #5946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go client required sending v2 auth, but receiving v1 responses - this change makes it consistently use v1 auth. The JS client incorrectly closed the stream only after it had received headers - now it can close right away, and just wait for headers to arrive normally. Prerequisite to deephaven#5922
niloc132
added
NoDocumentationNeeded
release blocker
kosak
previously approved these changes
Aug 15, 2024
niloc132
commented
Aug 16, 2024
Comment on lines
+188
to
+191
| tkn, err = requestToken(handshakeClient, "Bearer", oldToken) | ||
| } else { | ||
| log.Println("Old token has an error during token update. Attempting to acquire a fresh token. err=", err) | ||
| tkn, err = requestToken(handshakeClient, &flight.HandshakeRequest{Payload: []byte(authString)}) | ||
| tkn, err = requestToken(handshakeClient, authType, []byte(authToken)) |
There was a problem hiding this comment.
Corey pointed out that I wasn't calling these methods in the new way - updated the patch to take the type/token as params, so that the new wrapper logic lives in just once place.
chipkent
approved these changes
Aug 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go client required sending v2 auth, but receiving v1 responses - this change makes it consistently use v1 auth.
The JS client incorrectly closed the stream only after it had received headers - now it can close right away, and just wait for headers to arrive normally.
Prerequisite to #5922