Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Remove Unnecessary Recursion from Select/Update #5924

Merged
merged 8 commits into from
Aug 15, 2024
Merged

perf: Remove Unnecessary Recursion from Select/Update #5924

merged 8 commits into from
Aug 15, 2024

Conversation

nbauernfeind
Copy link
Member

This is a stepping stone toward #4896; enabling a more obvious pattern of control that can support the additional restrictions.

@nbauernfeind nbauernfeind added clean up core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Aug 10, 2024
@nbauernfeind nbauernfeind added this to the 0.36.0 milestone Aug 10, 2024
@nbauernfeind nbauernfeind requested a review from rcaudy August 10, 2024 18:18
@nbauernfeind nbauernfeind self-assigned this Aug 10, 2024
rcaudy
rcaudy reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, lots of discussion

...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/analyzers/BaseLayer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
@nbauernfeind nbauernfeind requested a review from rcaudy August 14, 2024 22:00
rcaudy
rcaudy reviewed Aug 15, 2024
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review comments from today.

engine/table/src/main/java/io/deephaven/engine/table/impl/lang/QueryLanguageParser.java Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/lang/QueryLanguageParser.java Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/AbstractFormulaColumn.java Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/select/AbstractFormulaColumn.java Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
@nbauernfeind nbauernfeind requested a review from rcaudy August 15, 2024 16:11
rcaudy
rcaudy reviewed Aug 15, 2024
View reviewed changes
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
...ble/src/main/java/io/deephaven/engine/table/impl/select/analyzers/SelectAndViewAnalyzer.java Outdated Show resolved Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/SelectOrUpdateListener.java Outdated Show resolved Hide resolved
@nbauernfeind nbauernfeind requested a review from rcaudy August 15, 2024 22:28
@nbauernfeind nbauernfeind enabled auto-merge (squash) August 15, 2024 23:19
@nbauernfeind nbauernfeind merged commit 663fae6 into deephaven:main Aug 15, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

Assignees

@nbauernfeind nbauernfeind

Labels
clean up core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nbauernfeind @rcaudy