Skip to content

Commit

Permalink
fix: Add numpy as a required dependency for py client (#6308)
Browse files Browse the repository at this point in the history
and clean up setup.py a bit

Fixes #6304
  • Loading branch information
jmao-denver authored Oct 29, 2024
1 parent 09eeedb commit 640ab8f
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions py/client/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,13 @@
from pkg_resources import parse_version
from setuptools import find_packages, setup


def _get_readme() -> str:
# The directory containing this file
HERE = pathlib.Path(__file__).parent
here = pathlib.Path(__file__).parent
# The text of the README file
return (HERE / "README.md").read_text(encoding="utf-8")
return (here / "README.md").read_text(encoding="utf-8")


def _normalize_version(java_version):
partitions = java_version.partition("-")
Expand All @@ -24,9 +26,11 @@ def _normalize_version(java_version):
python_version = f"{regular_version}+{local_segment}" if local_segment else regular_version
return str(parse_version(python_version))


def _compute_version():
return _normalize_version(os.environ['DEEPHAVEN_VERSION'])


setup(
name='pydeephaven',
version=_compute_version(),
Expand Down Expand Up @@ -54,6 +58,7 @@ def _compute_version():
install_requires=['pyarrow',
'bitstring',
'grpcio',
'protobuf'],
'protobuf',
'numpy'],
package_data={'pydeephaven': ['py.typed']}
)

0 comments on commit 640ab8f

Please sign in to comment.