Check already generated address when receiving mined tx#3178
Closed
guilhermemntt wants to merge 3 commits intodecred:masterfrom
Closed
Check already generated address when receiving mined tx#3178guilhermemntt wants to merge 3 commits intodecred:masterfrom
guilhermemntt wants to merge 3 commits intodecred:masterfrom
Conversation
guilhermemntt
force-pushed
the
guilhermemntt-check-already-generated-address
branch
from
5bd813c to
bdb2a42
Compare
Check for already generated address only in current account
Simplify spent DCR checking
guilhermemntt
force-pushed
the
guilhermemntt-check-already-generated-address
branch
from
7958668 to
e5dc19d
Compare
Member
|
Closing due to age. And not sure relying on a new dcrwallet request is the best way to solve this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on decred/dcrwallet#1967 and closes #3145.
This PR ensures that the current address stored in decrediton -
nextAddress- is renewed if it was already used in some previous transaction and, in this way, strengthens the user's privacy. This checking is performed throughgetReceivedByAddressgRPC call to dcrwallet every time a new transaction is received.