More v2.0.6 backports #2472
Merged
More v2.0.6 backports #2472
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallet.Config is created in three separate places (create new wallet, open existing wallet, watch only wallet). DisableMixing was only being set correctly in one of those (watch only). As a result, a MixClient would always be created regardless of config set by the user. Backport of 7552d0b.
The ordered shutdown of wallet goroutines before closing the websocket connection introduced a new bug where the RPC syncer would hang if the dcrd connection is lost before clean shutdown is signaled, due to a missing call to cancel the context passed to Wallet.Run. Backport of d3e2a05.
dajohi
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.