Move address definitions to payments package#1820
Open
jrick wants to merge 1 commit intodecred:masterfrom
Open
Move address definitions to payments package#1820jrick wants to merge 1 commit intodecred:masterfrom
jrick wants to merge 1 commit intodecred:masterfrom
Conversation
The wallet.NetworkBackend interface is now able to use dcrwallet's own Address interface rather than using dcrutil in the definition. This required moving the interfaces and several implementations to be moved from the wallet package to a new payments package to avoid a package import cycle. The old wallet.KnownAddress interface is renamed to wallet.Address since it is no longer confused with the previous wallet.Address interface (which becomes a payments interface).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wallet.NetworkBackend interface is now able to use dcrwallet's own
Address interface rather than using dcrutil in the definition. This
required moving the interfaces and several implementations to be moved
from the wallet package to a new payments package to avoid a package
import cycle.