Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add market making #3166

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

docs: add market making #3166

wants to merge 5 commits into from

Conversation

bochinchero
Copy link
Contributor

@bochinchero bochinchero commented Jan 29, 2025 •
edited
Loading

Addresses the mm portion of #2990 and #2897

  • Market Making
    - Basic Market Maker
    - Market Maker + Arbitrage
    - Basic Arbitrage
    - Configure CEX API Access
    - Binance / Binance US

@bochinchero bochinchero marked this pull request as ready for review January 30, 2025 11:03
@bochinchero bochinchero marked this pull request as draft January 30, 2025 11:06
@JoeGruffins
Copy link
Member

Thanks for doing this.

If you look at the Files changed tab at the bottom theres a bunch of GitHub Actions / Lint Markdown errors. Are you able to fix those?

@bochinchero
Copy link
Contributor Author

Thanks for doing this.

If you look at the Files changed tab at the bottom theres a bunch of GitHub Actions / Lint Markdown errors. Are you able to fix those?

yeah, will fix those as part of this PR.

martonp
martonp reviewed Feb 1, 2025
View reviewed changes
Copy link
Collaborator

@martonp martonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

martonp
martonp reviewed Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@martonp martonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really great. Are you still planning to add sections for Arb Market Maker and Simple Arb?

docs/wiki/Market-Making.md

<img src="./images/using-bison-wallet/mm-basic-running.png" width="800" alt="">

The bot can be stopped by pressing the `Stop` button, or deleted by pressing the <img src="./images/using-bison-wallet/mm-delete-button.png" width="20" alt=""> button.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The delete button you're showing is the view logs button.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I noticed this after I pushed this, will correct - I will be adding the arb+mm and simple arb.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martonp martonp martonp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bochinchero @JoeGruffins @martonp