mm: Add live config and balance updates for running bots #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2025
|
Just tested. This is a much more intuitive sequence. I did struggle the first time I set up bots with the older sequencing .. so this new UI/UX has better chance for a new end user. |
martonp
force-pushed
the
viewRunningBotSettings
branch
2 times, most recently
from
b85d3bb to
5c38a75
Compare
|
Let's progress this out of draft. This is looking good. I'll have lots of followup, but no reason to hold this up any longer. |
martonp
force-pushed
the
viewRunningBotSettings
branch
from
5c38a75 to
169a72d
Compare
martonp
changed the title
This change introduces live balance and configuration updates for active bots, along with UI improvements. Starting bots and bot balance allocation now occurs on the 'mmsettings' page (instead of the main 'mm' page). Two allocation options are now available: - Quick config: Set buffers based on the number of lots to match on the same side before funds run low. Also possible to set a slippage buffer for the quote asset and fee reserves for EVM assets. - Manual config: Specify exact asset amounts to allocate to the bot.
martonp
force-pushed
the
viewRunningBotSettings
branch
from
169a72d to
fcf000b
Compare
JoeGruffins
reviewed
Mar 21, 2025
There was a problem hiding this comment.
Trying on simnet, unable to start with:
POST | http://127.0.0.3:5758/api/startmarketmakingbot
Status
400
Bad Request
client log:
2025-03-21 06:58:58.566 [DBG] WEB: failed to unmarshal JSON request: json: cannot unmarshal number 13381842.214293646 into Go struct field BotBalanceAllocation.config.alloc.dex of type uint64
2025-03-21 06:58:58.566 [DBG] WEB: raw request: {"config":{"baseID":60,"quoteID":0,"host":"127.0.0.1:17273","alloc":{"dex":{"0":13381842.214293646,"60":4141531800},"cex":{"0":0,"60":0}}}}
2025-03-21 06:58:58.566 [ERR] WEB: failed to read form
Also the console is logging this over and over at some point:
Object { dex: {…}, cex: {…} }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces live balance and configuration updates
for active bots, along with UI improvements. Starting bots and bot
balance allocation now occurs on the 'mmsettings' page (instead of
the main 'mm' page). Two allocation options are now available:
the same side before funds run low. Also possible to set a slippage
buffer for the quote asset and fee reserves for EVM assets.
The simple arb bot UI now only has one bot parameter, "Profit Threshold". The number of lots is now set in the "Asset Allocation" section.