Add option to control emission of noload segment#79
Open
polybiusproxy wants to merge 1 commit intodecompals:mainfrom
Open
Add option to control emission of noload segment#79polybiusproxy wants to merge 1 commit intodecompals:mainfrom
noload segment#79polybiusproxy wants to merge 1 commit intodecompals:mainfrom
Conversation
AngheloAlf
reviewed
Dec 21, 2025
Contributor
AngheloAlf
left a comment
AngheloAlf
left a comment
There was a problem hiding this comment.
I like the idea of avoid emitting all the stuff from the noload segment, including linker symbols and such, but I'm not so sure about making it a new setting because you can end up with a list of sections in noload_sections but emit_noload_segment: False which may be counterintuitive to the user.
Maybe we could make noload_sections nullable instead, so if you don't want those to get emitted then you would just do noload_sections: null instead of noload_sections: [] & emit_noload_segment: False
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds option to control the emission of the
.noloadsegment. Defaults to true.Documentation hasn't been added yet.