fix(monitoring): implement proper infinite scroll with log accumulation #2141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the monitoring scroll issue where logs were being replaced instead of accumulated when scrolling to the bottom.
Problem
The monitoring logs table was using URL-based pagination that replaced all logs with the next page's logs when scrolling to the bottom. Users expected infinite scroll behavior where new logs append to existing ones.
Solution
useSuspenseInfiniteQueryfrom React Querydata.pagesisLoadingguard touseInfiniteScrollhook to prevent duplicate triggersuseCallbackto prevent unnecessary IntersectionObserver recreationpageparameter from URL (pagination now handled internally)Changes
apps/mesh/src/web/routes/orgs/monitoring.tsx- UseuseSuspenseInfiniteQueryfor proper infinite scrollapps/mesh/src/web/hooks/use-infinite-scroll.ts- AddisLoadingparam and memoize callbackTesting
Summary by cubic
Implemented true infinite scroll in Monitoring so logs append as you reach the bottom instead of replacing the list. This replaces URL-based pagination with React Query infinite queries and keeps streaming mode working.
Written for commit 43095b4. Summary will update on new commits.