feat: chat autorefresh #2127
Merged
feat: chat autorefresh #2127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🧪 BenchmarkShould we run the MCP Gateway benchmark for this PR? React with 👍 to run the benchmark.
Benchmark will run on the next push after you react. |
Contributor
Release OptionsShould a new version be published when this PR is merged? React with an emoji to vote on the release type:
Current version: Deployment
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 17 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/mesh/src/web/components/details/assistant/index.tsx">
<violation number="1" location="apps/mesh/src/web/components/details/assistant/index.tsx:548">
P2: Remove the `title` attribute since `TooltipContent` already provides the tooltip. Having both causes duplicate tooltips (native browser + custom) on hover.</violation>
<violation number="2" location="apps/mesh/src/web/components/details/assistant/index.tsx:566">
P2: Remove the `title` attribute since `TooltipContent` already provides the tooltip. Having both causes duplicate tooltips (native browser + custom) on hover.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| <Button | ||
| type="button" | ||
| onClick={() => setMode("edit")} | ||
| title="Edit" |
Contributor
There was a problem hiding this comment.
P2: Remove the title attribute since TooltipContent already provides the tooltip. Having both causes duplicate tooltips (native browser + custom) on hover.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/mesh/src/web/components/details/assistant/index.tsx, line 566:
<comment>Remove the `title` attribute since `TooltipContent` already provides the tooltip. Having both causes duplicate tooltips (native browser + custom) on hover.</comment>
<file context>
@@ -523,30 +532,49 @@ function AssistantDetailContent({
+ <Button
+ type="button"
+ onClick={() => setMode("edit")}
+ title="Edit"
+ aria-label="Edit"
+ variant="outline"
</file context>
✅ Addressed in d7665a4
| <Button | ||
| type="button" | ||
| onClick={() => setActiveThreadId(crypto.randomUUID())} | ||
| title="New thread" |
Contributor
There was a problem hiding this comment.
P2: Remove the title attribute since TooltipContent already provides the tooltip. Having both causes duplicate tooltips (native browser + custom) on hover.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/mesh/src/web/components/details/assistant/index.tsx, line 548:
<comment>Remove the `title` attribute since `TooltipContent` already provides the tooltip. Having both causes duplicate tooltips (native browser + custom) on hover.</comment>
<file context>
@@ -523,30 +532,49 @@ function AssistantDetailContent({
+ <Button
+ type="button"
+ onClick={() => setActiveThreadId(crypto.randomUUID())}
+ title="New thread"
+ aria-label="New thread"
+ variant="outline"
</file context>
✅ Addressed in d7665a4
tlgimenes
force-pushed
the
feat/chat-autorefresh
branch
from
d7665a4 to
32e0f48
Compare
… logic. Updated imports and adjusted MessageTextPart to accept a part prop instead of text. Enhanced MessagePart function for better clarity and maintainability.
…ionId optional for backward compatibility. Updated PinToSidebarButton to use URL instead of connectionId across various components, enhancing consistency and usability.
…proved UI consistency. Updated button titles and styles, integrated ViewLayout in WorkflowDetails, and enhanced WorkflowEditorHeader with new components and layout adjustments.
…, and WorkflowEditorHeader components by integrating tooltips for action buttons. Updated button imports and styles for improved accessibility and user experience.
…improve type usage. Introduced useInvalidateCollectionsOnToolCall hook for automatic query invalidation during tool calls in chat. Updated useCollectionItem and useCollectionList to include organization context in query keys, ensuring better data management and UI responsiveness.
…y and enhance data handling. Updated onUpdate method to accept Partial<Workflow> for better type management. Removed unnecessary imports and console logs, and integrated EmptyState for improved user feedback when workflows are not found.
tlgimenes
force-pushed
the
feat/chat-autorefresh
branch
from
8c99b45 to
c0828a1
Compare
Contributor
Author
Contributor
|
@tlgimenes I have started the AI code review. It will take a few minutes to complete. |
Contributor
There was a problem hiding this comment.
1 issue found across 26 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/mesh/src/web/components/details/workflow/index.tsx">
<violation number="1" location="apps/mesh/src/web/components/details/workflow/index.tsx:35">
P2: The `onUpdate` prop is declared as required in `WorkflowDetailsViewProps` but is never used in the component implementation. Either remove it from the interface or use the prop instead of the locally created `update` function.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this contribution about?
Screenshots/Demonstration
Review Checklist
Summary by cubic
Adds auto-refresh to chat and collection lists, and lets users pin the current view to the sidebar. Also simplifies message rendering and switches sidebar pins to use URLs instead of connection IDs.
New Features
Refactors
Written for commit 7c4a6af. Summary will update on new commits.