Use deployment id on render #937
Conversation
Tagging OptionsShould a new tag be published when this PR is merged?
|
| const opts = fromRequest(req); | ||
| if (opts.deploymentId && deploymentId) { | ||
| if (opts.deploymentId !== deploymentId) { | ||
| throw badRequest({ |
There was a problem hiding this comment.
Is this necessary? What do you think about logging the error but not failing the request?
There was a problem hiding this comment.
Perhaps we need to fail the request so a second one can cache the right response. If we dont fail will the "not failure" request be cached?
There was a problem hiding this comment.
what if we return max-age 0?
There was a problem hiding this comment.
We already have this issue with assets. If we request an asset on a older deploy, it will give an 404.
It is better to fail fast and let the CDN cache on a successful response, and try to fix this issue with another approach.
| import type { PageParams } from "../mod.ts"; | ||
| import Render, { type PageData } from "./entrypoint.tsx"; | ||
|
|
||
| const deploymentId = Deno.env.get("DENO_DEPLOYMENT_ID"); |
There was a problem hiding this comment.
Will it exists in all platforms?
There was a problem hiding this comment.
This already exists in context, shouldn't import it from context?
There was a problem hiding this comment.
This is not on the fresh context (what is used there).
No description provided.