feat: dynamic lights #1049
Open
feat: dynamic lights #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Tween to support YOYO repeat mode in TweenSequence. Added test for TextureMove tween
Deploying js-sdk-toolchain with
|
| Latest commit: |
5721418
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e9032053.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://feat-dynamic-lights.js-sdk-toolchain.pages.dev |
# Conflicts: # package-lock.json # package.json # packages/@dcl/playground-assets/etc/playground-assets.api.md
Test this pull request
|
# Conflicts: # package-lock.json # package.json # packages/@dcl/playground-assets/etc/playground-assets.api.md # test/snapshots/development-bundles/static-scene.test.ts.crdt # test/snapshots/development-bundles/testing-fw.test.ts.crdt # test/snapshots/development-bundles/two-way-crdt.test.ts.crdt # test/snapshots/production-bundles/append-value-crdt.ts.crdt # test/snapshots/production-bundles/billboard.ts.crdt # test/snapshots/production-bundles/cube-deleted.ts.crdt # test/snapshots/production-bundles/cube.ts.crdt # test/snapshots/production-bundles/cubes.ts.crdt # test/snapshots/production-bundles/pointer-events.ts.crdt # test/snapshots/production-bundles/schema-components.ts.crdt # test/snapshots/production-bundles/ui.ts.crdt # test/snapshots/production-bundles/with-main-function.ts.crdt
pravusjif
approved these changes
Jan 27, 2025
|
And also of course fix the CI lint (running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initiative Notion: https://www.notion.so/decentraland/Dynamic-lights-85cc7dbac80f4df28ac47d82483c3ba6
Related PRs
Protocol PR: decentraland/protocol#234
E@ PR: decentraland/unity-explorer#3113