Manage batch processing in Debezium Extensions for Quarkus #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kmos <[email protected]>
Signed-off-by: kmos <[email protected]>
Signed-off-by: kmos <[email protected]>
Signed-off-by: kmos <[email protected]>
…yncEngineBuilderFactory Signed-off-by: kmos <[email protected]>
Signed-off-by: kmos <[email protected]>
Signed-off-by: kmos <[email protected]>
Signed-off-by: kmos <[email protected]>
…events Signed-off-by: kmos <[email protected]>
Signed-off-by: kmos <[email protected]>
Signed-off-by: kmos <[email protected]>
Signed-off-by: kmos <[email protected]>
jpechane
reviewed
Jan 8, 2026
| <dependency> | ||
| <groupId>org.apache.kafka</groupId> | ||
| <artifactId>connect-api</artifactId> | ||
| <scope>provided</scope> |
|
|
||
| import org.apache.kafka.connect.source.SourceRecord; | ||
|
|
||
| public interface BatchEvent { |
Contributor
There was a problem hiding this comment.
Do we really want to operate at this level? Can't we extend CapturingEvent class to add commit or similar methods.
Suggested change
| public interface BatchEvent { | |
| public interface ComittingCapturingEvent extends CapturingEvent { |
| private final AtomicInteger isCapturingFilteredEvent = new AtomicInteger(0); | ||
|
|
||
| @Capturing(destination = "topic.inventory.products") | ||
| public void capture(CapturingEvents<BatchEvent> events) { |
Contributor
There was a problem hiding this comment.
Can't we take a bit different approach so the user will use somehing like
Suggested change
| public void capture(CapturingEvents<BatchEvent> events) { | |
| public void capture(List<CommittedCapturingEvent> events) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes debezium/dbz#1484