Open
Conversation
use formatTitle(article) instead of article.title in obsidian func
use formatTitle(article) instead of article.title in obsidian func
Detailed instructions on how to use obsidian integration.
attribute which matches removal criteria. Removal of the HTML element causies Markdownload to fail because: * the pageTitle is undefined * basicUri point to chrome-extension://nghfdnngoejlhedogdpikdlkmdfoojii/_generated_background_page.html rather than the actual web page * all local links are incorrect
web page's base. Some website specify the href of the base tag as '/'. This causes the JDOMParser to set: * dom.baseURI = 'chrome-extension://nghfdnngoejlhedogdpikdlkmdfoojii/' * dom.documentURI = 'chrome-extension://nghfdnngoejlhedogdpikdlkmdfoojii/_generated_background_page.html' when it parse HTML text in the background context and subsequently Readability.js genarates garbage for local links
…e has a value and download can succeed.
… was ripped out from its owning 'pre' and the code.innerText lost all spacings and linefeeds. In addition a second fix was needed because all tabs where stripped in the turndown function (bachground.js). This caused code to loose indent and look unreadable.
…ich do not contain a `<code>` cild element. This allows `<pre>` blocks to be rendered as markdown fenced blocks.
Fix a typo in README.md
Resolve Obsidian Filename Determination Issue in background.js
Prevent Readability.js from removing the <html> element if it has a class attribute with specific values
Make sure the 'href' attribute of the base tag points to the web page's base..
Make sure the document processed in background.js has a title element.
Fixed unreadable code blocks.
Readability.js component updated to version 0.5.0
Turndown.js update to 7.1.3
add lowercase and uppercase parameterizations
Added additional parameterization options
Fix deathau#340 - Whitespace issues while saving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manifest V3 Migration with UI Optimizations
📋 Summary
This PR completes the migration from Manifest V2 to Manifest V3 for the MarkDownload browser extension, along with significant UI optimizations and bug fixes. This builds upon the initial Manifest V3 work by adding crucial improvements to the popup interface, fixing image download functionality, and enhancing the overall user experience.
🚀 Key Changes
🔧 Manifest V3 Migration Enhancements
🎨 UI/UX Improvements
🗂️ Code Organization
📁 Files Changed
Core Extension Files
src/manifest.json- Updated to Manifest V3 specificationsrc/background/service-worker.js- New service worker implementationsrc/contentScript/contentScript.js- Enhanced content script with V3 compatibilitysrc/popup/popup.js- Optimized popup interfacesrc/options/options.js- Updated options handling for V3Library and Dependencies
src/background/- Reorganized and updated all background librariessrc/browser-polyfill.min.js- Added for cross-browser compatibilitysrc/background/background.js(legacy V2 background script)src/contentScript/getSelectionAndDom.js(consolidated into main content script)🧪 Testing Performed
✅ Core Functionality Tests