Skip to content

[feature/#40] HomeHashtag 컴포넌트 구현 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyeminililo merged 9 commits into from
Mar 8, 2026
+160 −1
Merged

[feature/#40] HomeHashtag 컴포넌트 구현 #41

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
82caa39
feature/#40: HomeHashtag 컴포넌트 구현
hyeminililo Feb 20, 2026
2bda682
feature/#40: HomeSectionTrailingAction 컴포넌트 구현
hyeminililo Feb 20, 2026
f155b8a
chore/#40: ktLint 실행
hyeminililo Feb 20, 2026
7f15b1f
refactor/#40: 코드리뷰 기반으로 리팩토링 진행
hyeminililo Mar 6, 2026
d3cf5cc
refactor/#40: 코드리뷰 기반으로 리팩토링 진행
hyeminililo Mar 6, 2026
529a724
chore/#40: ktLint 실행
hyeminililo Mar 6, 2026
7e03658
chore/#40: ktLint 실행
hyeminililo Mar 6, 2026
3c54f66
refactor/#40 : DS Micro2 TextStyle 추가
hyeminililo Mar 6, 2026
fe29abf
Merge branch 'dev' into feature/#40-home-component
hyeminililo Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions app/src/main/java/com/gildongmu/dduru/presentation/feature/home/component/HomeHashtag.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
package com.gildongmu.dduru.presentation.feature.home.component

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import com.gildongmu.dduru.core.designsystem.theme.DduruTheme

@Composable
fun HomeHashtag(
text: String,
modifier: Modifier = Modifier
) {
Box(
modifier = modifier
.clip(shape = RoundedCornerShape(size = 99.dp))
.background(color = DduruTheme.colors.gray300.copy(alpha = 0.3f))
.padding(horizontal = 12.dp, vertical = 8.dp),
contentAlignment = Alignment.Center
) {
Text(
text = "#$text",
color = DduruTheme.colors.gray300,
style = DduruTheme.typography.Caption2
)
}
}

@Preview(name = "HomeHashtag - Default")
@Composable
private fun HomeHashtagDefaultPreview() {
HomeHashtag(text = "사진")
}

@Preview(name = "HomeHashtag - LongText")
@Composable
private fun HomeHashtagLongTextPreview() {
HomeHashtag(text = "카페투어")
}
54 changes: 54 additions & 0 deletions ...java/com/gildongmu/dduru/presentation/feature/home/component/HomeSectionTrailingAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
package com.gildongmu.dduru.presentation.feature.home.component

import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.filled.KeyboardArrowRight
import androidx.compose.material3.Icon
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import com.gildongmu.dduru.core.designsystem.theme.DduruTheme

@Composable
fun HomeSectionTrailingAction(
text: String,
onClick: () -> Unit,
modifier: Modifier = Modifier
) {
Row(
modifier = modifier
.fillMaxWidth()
.clickable(onClick = onClick)
.padding(vertical = 4.dp),
Comment on lines +24 to +27
Copy link

@coderabbitai coderabbitai bot Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

find . -name "HomeSectionTrailingAction.kt" -type f

Repository: ddu-ru/ddu-ru-android

Length of output: 169

🏁 Script executed:

cat -n ./app/src/main/java/com/gildongmu/dduru/presentation/feature/home/component/HomeSectionTrailingAction.kt

Repository: ddu-ru/ddu-ru-android

Length of output: 2059

🏁 Script executed:

# Check the design system theme to understand Body4 text style dimensions
fd -t f "theme" "app/src/main/java/com/gildongmu/dduru/core/designsystem" | head -20

Repository: ddu-ru/ddu-ru-android

Length of output: 135

🏁 Script executed:

# Let's look at the Typography definitions to understand Body4 dimensions
rg "Body4|body4" app/src/main/java/com/gildongmu/dduru/core/designsystem -A 2 -B 2 -t kt

Repository: ddu-ru/ddu-ru-android

Length of output: 91

🏁 Script executed:

cat -n app/src/main/java/com/gildongmu/dduru/core/designsystem/theme/Theme.kt | head -100

Repository: ddu-ru/ddu-ru-android

Length of output: 2492

🏁 Script executed:

fd -t f "Typography" app/src/main/java/com/gildongmu/dduru/core/designsystem/typography

Repository: ddu-ru/ddu-ru-android

Length of output: 47

🏁 Script executed:

rg "Body4" app/src/main/java/com/gildongmu/dduru/core/designsystem -A 3 -B 1

Repository: ddu-ru/ddu-ru-android

Length of output: 1051

🏁 Script executed:

cat -n app/src/main/java/com/gildongmu/dduru/core/designsystem/typography/Type.kt

Repository: ddu-ru/ddu-ru-android

Length of output: 5511

🏁 Script executed:

# Check if there are any size/dimension constants defined for touch targets
rg "48.dp|minHeight|touchTarget" app/src/main/java/com/gildongmu/dduru --max-count 20

Repository: ddu-ru/ddu-ru-android

Length of output: 280

🏁 Script executed:

# Check if there are any other similar components that define minimum touch target sizes
rg "sizeIn|minHeight|minWidth" app/src/main/java/com/gildongmu/dduru/presentation -A 1 -B 1 | head -40

Repository: ddu-ru/ddu-ru-android

Length of output: 47

🏁 Script executed:

# Verify Material Design guidelines for touch targets by checking Android documentation context
# Also check if this component is used in a context where touch target size might be constrained
rg "HomeSectionTrailingAction" app/src/main/java/com/gildongmu/dduru/presentation -B 2 -A 2

Repository: ddu-ru/ddu-ru-android

Length of output: 1564

🏁 Script executed:

# Check Icon default size in Material3
rg "Icon" app/src/main/java/com/gildongmu/dduru/presentation/feature/home/component/HomeSectionTrailingAction.kt -A 5

Repository: ddu-ru/ddu-ru-android

Length of output: 623

🏁 Script executed:

# Verify how other clickable components in the app handle touch targets
fd "Button" app/src/main/java/com/gildongmu/dduru/core/designsystem/component -type f

Repository: ddu-ru/ddu-ru-android

Length of output: 235

🏁 Script executed:

# Check the exact usage location of this component to see if it's constrained
rg "HomeSectionTrailingAction" app/src/main/java/com/gildongmu/dduru/presentation/feature/home -B 5 -A 5

Repository: ddu-ru/ddu-ru-android

Length of output: 3022

🏁 Script executed:

# Verify Icon default size by checking Material3 documentation context in the codebase
rg "Icon\(" app/src/main/java/com/gildongmu/dduru --max-count 10 -A 3 | head -50

Repository: ddu-ru/ddu-ru-android

Length of output: 646

최소 터치 영역 48.dp를 보장하도록 명시하세요.

현재 코드에서 Row의 높이는 Body4 텍스트(약 17.6.sp 라인 높이)와 기본 아이콘 크기(24.dp)에 상하 패딩 8.dp만 더해져 약 32dp에 불과합니다. 이는 Material Design 3의 권장 최소 터치 영역 48.dp에 미치지 못합니다. sizeIn(minHeight = 48.dp)를 .clickable() 전에 추가하여 접근성을 개선하세요.

🔧 제안하는 수정 
 import androidx.compose.foundation.clickable
 import androidx.compose.foundation.layout.Arrangement
 import androidx.compose.foundation.layout.Row
 import androidx.compose.foundation.layout.padding
+import androidx.compose.foundation.layout.sizeIn
 ...
     Row(
         modifier = modifier
+            .sizeIn(minHeight = 48.dp)
             .clickable(onClick = onClick)
             .padding(vertical = 4.dp),
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Row(
modifier = modifier
.clickable(onClick = onClick)
.padding(vertical = 4.dp),
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.sizeIn
Row(
modifier = modifier
.sizeIn(minHeight = 48.dp)
.clickable(onClick = onClick)
.padding(vertical = 4.dp),
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In
`@app/src/main/java/com/gildongmu/dduru/presentation/feature/home/component/HomeSectionTrailingAction.kt`
around lines 24 - 27, The Row in HomeSectionTrailingAction is too short for the
recommended 48.dp touch target; update the modifier chain to enforce a minimum
height by inserting sizeIn(minHeight = 48.dp) before .clickable(onClick =
onClick) (i.e., apply sizeIn on the same modifier used for Row so the clickable
area meets Material 3 touch target guidelines).

Copy link
Collaborator Author

@hyeminililo hyeminililo Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳이?

verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(8.dp)
) {
Text(
text = text,
style = DduruTheme.typography.Body4,
color = DduruTheme.colors.gray600
)

Icon(
imageVector = Icons.AutoMirrored.Filled.KeyboardArrowRight,
contentDescription = null,
tint = DduruTheme.colors.gray600
)
Comment on lines +37 to +41
Copy link

@coderabbitai coderabbitai bot Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

클릭 가능한 Row에 접근성(semantics) 레이블 누락

clickable Row 전체가 하나의 인터랙션 요소이지만, Row에도 Icon에도 접근성 설명이 없어 스크린 리더가 동작을 안내하지 못합니다.

Icon의 contentDescription = null은 텍스트가 충분한 컨텍스트를 제공하는 경우 허용되지만, clickable Modifier에 semantics 블록을 추가해 role과 contentDescription을 명시하는 것을 권장합니다.

♿ 접근성 개선 제안 
     Row(
         modifier = modifier
             .fillMaxWidth()
-            .clickable(onClick = onClick)
+            .clickable(
+                onClick = onClick,
+                onClickLabel = text
+            )
             .padding(vertical = 4.dp),
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Icon(
imageVector = Icons.AutoMirrored.Filled.KeyboardArrowRight,
contentDescription = null,
tint = DduruTheme.colors.gray600
)
Row(
modifier = modifier
.fillMaxWidth()
.clickable(
onClick = onClick,
onClickLabel = text
)
.padding(vertical = 4.dp),
) {
Icon(
imageVector = Icons.AutoMirrored.Filled.KeyboardArrowRight,
contentDescription = null,
tint = DduruTheme.colors.gray600
)
}
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In
`@app/src/main/java/com/gildongmu/dduru/presentation/feature/home/component/HomeSectionTrailingAction.kt`
around lines 39 - 43, The clickable Row in HomeSectionTrailingAction.kt lacks
accessibility semantics; update the Row's Modifier (the same one that uses
clickable) to include a semantics block that sets role = Role.Button and a
meaningful contentDescription string describing the action (e.g., "Open section"
or context-specific label), and keep the Icon's contentDescription = null so the
Row-level label is used by screen readers; reference the Row modifier in
HomeSectionTrailingAction and import androidx.compose.ui.semantics.Role and
semantics.

}
}

@Preview
@Composable
private fun HomeSectionTrailingActionPreview() {
HomeSectionTrailingAction(
text = "전체보기",
onClick = {}
)
}