Proof of concept reporter interface #241
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my first attempt at implementing the idea in issue ddeboer#100
Contributor
Author
|
Personally I kinda think that the exceptions should be stored in the report as well. Thoughts? |
This allows a report message to have a severity.
When an exception occurs we need to record any messages and then continue the loop, otherwise the imported count gets incremented erroneously.
Sometimes a filter may provide detailed information regarding why it is rejecting a particular row. Without detecting that a message exists it will be lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt at implementing the idea in issue #100
Thoughts or feedback?