Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pagination): fix width of select page and prevent default in handle change select #199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(pagination): fix width of select page and prevent default in handle change select #199

wants to merge 1 commit into from

Conversation

carlos-yacante-dd3
Copy link
Contributor

…

Summary

  • Error when changing the page number, it changes the url of the route.
  • When the page number is three digits, it is not displayed correctly.

Task

  • Not yet

Affected sections

  • src\components\Pagination\Pagination.tsx

How did you test this change?

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

tbor00
tbor00 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@tbor00 tbor00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, please rebase and merge 🙏🏻 @carlos-yacante-dd3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbor00 tbor00 tbor00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlos-yacante-dd3 @tbor00 @Carlitox7