Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-90: Add audio recording demo #13

Merged
merged 3 commits into from
Mar 29, 2025
Merged

DEV-90: Add audio recording demo #13

merged 3 commits into from
Mar 29, 2025

Conversation

tonyhu-x
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@krishnacheemalapati krishnacheemalapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove or comment out the console.log statements when we're pushing things to prod. Other than that, looks good!

@tonyhu-x
Copy link
Collaborator Author

Logging should now be disabled. However, since processor.js is not treated as app code, I manually commented out the log statements in the original source and re-compiled a new version.

@tonyhu-x
Copy link
Collaborator Author

The previous commit was to fix a problem that didn't appear when testing using npm run dev. I had to do some fixing on the recorder library end. I kept track of what I did there, so I will not document it within our project.

@tonyhu-x tonyhu-x merged commit dfe2254 into main Mar 29, 2025
3 checks passed
@tonyhu-x tonyhu-x deleted the DEV-90 branch March 29, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants