Skip to content

Use with block to avoid deadlock #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use with block to avoid deadlock #40

wants to merge 1 commit into from

Conversation

@eugene-eeo
Copy link

@eugene-eeo eugene-eeo commented Aug 16, 2014

If any of the IO actions fail at least the lock would be released.

@d0ugal
Copy link

d0ugal commented Aug 16, 2014

LGTM.

getaaron
getaaron approved these changes Jan 12, 2020
View reviewed changes
Copy link

@getaaron getaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcramer could we please get a merge on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@getaaron getaaron getaaron approved these changes

@hari90 hari90 hari90 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eugene-eeo @d0ugal @getaaron @hari90