Adding partition/cluster functionality to bigquery mv config #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed_view adapter Using logic similar to the partition/cluster code for a regular table, this commit adds this functionality to the bigquery materialized_view feature.
|
This would be an extremely helpful feature to have for us. Thank you. |
|
Definitely appreciate if this becomes a feature! |
|
@makermary Very cool, thanks for opening! I'll take a look in the next couple days. The MV code needs a bit of a refresh as is. |
Have you had any more thoughts on this @jtcohen6? This would be really useful for us. |
|
Having recently become enamored of BQ's clustering, this could be a huge help for us. Also I noticed @lihan's new PR:
From the dbt labs side, what would it take to get either of these contributions to included status? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using logic similar to the partition/cluster code for a regular table, this commit adds this functionality to the bigquery materialized_view feature.
Tested by replacing the code in my local install of dbt-labs-experimental-features. If a materialized view already exists without partitions, users must do a --full-refresh for the partition to exist.
Solves #28.