Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding partition/cluster functionality to bigquery mv config #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

makermary
Copy link
Contributor

@makermary makermary commented Apr 26, 2022

Using logic similar to the partition/cluster code for a regular table, this commit adds this functionality to the bigquery materialized_view feature.

Tested by replacing the code in my local install of dbt-labs-experimental-features. If a materialized view already exists without partitions, users must do a --full-refresh for the partition to exist.

Solves #28.

…ed_view adapter

Using logic similar to the partition/cluster code for a regular table, this commit adds this functionality to the bigquery materialized_view feature.
@waitsfornone
Copy link

This would be an extremely helpful feature to have for us. Thank you.

@minhnhat992
Copy link

Definitely appreciate if this becomes a feature!

@jtcohen6
Copy link
Collaborator

jtcohen6 commented May 6, 2022

@makermary Very cool, thanks for opening! I'll take a look in the next couple days. The MV code needs a bit of a refresh as is.

@judahrand
Copy link

@makermary Very cool, thanks for opening! I'll take a look in the next couple days. The MV code needs a bit of a refresh as is.

Have you had any more thoughts on this @jtcohen6? This would be really useful for us.

@riordan
Copy link

riordan commented Aug 31, 2022

Having recently become enamored of BQ's clustering, this could be a huge help for us.

Also I noticed @lihan's new PR:

From the dbt labs side, what would it take to get either of these contributions to included status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants