Skip to content

Conversation

@rolandwalker
Copy link
Contributor

Description

  • remove unused imports from main.py
  • remove unneeded pass statement
  • clean up unneeded list literals
  • remove needless whitespace
  • call endswith() only once with a tuple
  • fix needless generators, rule C400
  • fix needless list comprehension
  • prefer generator over map+lambda
  • disable sufficient rules for ruff check to pass
  • proactively add some known-first-party imports
  • enable ruff check in CI, modifying tox.ini such that files are checked but not modified

While there are many fixes, this leaves some individual rules disabled, to be enabled one-by-one in future PRs. The key thing is that checks are turned on in CI.

Checklist

  • I've added this contribution to the changelog.md.
  • I've added my name to the AUTHORS file (or it's already there).

@rolandwalker rolandwalker requested a review from amjith April 26, 2025 13:44
@rolandwalker rolandwalker self-assigned this Apr 26, 2025
@rolandwalker rolandwalker changed the title Enable minimal ruff check in CI Enable minimal ruff check in CI Apr 26, 2025
@rolandwalker rolandwalker merged commit fd7f50d into main Apr 26, 2025
6 checks passed
@rolandwalker rolandwalker deleted the RW/enable-minimal-ruff-check branch April 26, 2025 15:39
rolandwalker added a commit that referenced this pull request Apr 26, 2025
@rolandwalker rolandwalker mentioned this pull request Apr 26, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants