Add ruff format linting
#1207
Merged
Add ruff format linting
#1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tox lint check at the end of ci.yml doesn't seem to be showing lint errors. Add a separate lint action, a ruff configuration, and ruff-format the codebase. The changes are all whitespace, if joining strings can be considered whitespace. Passing "ruff check" would be more difficult.
Member
|
This is great. We should also look into adding a pre-commit integration to make sure we stay clean going forward. Litecli has a pre-commit config https://github.com/dbcli/litecli/blob/main/.pre-commit-config.yaml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tox lint check at the end of ci.yml doesn't seem to be showing lint errors.
Add a separate lint action, a ruff configuration, and ruff-format the codebase. The changes are all whitespace, if joining strings can be considered whitespace.
Passing "ruff check" would be more difficult.
Checklist
I've added this contribution to thethere is already an entry about linting, which is sufficient.changelog.md.AUTHORSfile (or it's already there).