feat(api): add partial index for recoverable sandboxes#4154
Open
brunogrbavac wants to merge 2 commits intomainfrom
Open
feat(api): add partial index for recoverable sandboxes#4154brunogrbavac wants to merge 2 commits intomainfrom
brunogrbavac wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: Bruno Grbavac <bruno.grbavac@outlook.com>
There was a problem hiding this comment.
Pull request overview
Adds a new TypeORM pre-deploy migration to improve performance when selecting “recoverable” sandboxes by introducing a partial index on the sandbox table.
Changes:
- Add a pre-deploy migration that creates a partial index for
sandboxrows whererecoverable = true. - Add rollback logic to drop the index.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Bruno Grbavac <bruno.grbavac@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a partial index on the sandbox table for rows where recoverable is true. Only a minuscule fraction of rows match this condition, so the index is tiny and eliminates full table scans when querying recoverable sandboxes on draining runners.
Documentation