Skip to content

V3migration for review #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: temp
Choose a base branch
from
Open

V3migration for review #1

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bf77f10
net/tap: Added TUNSETSTEERINGEBPF code.
AndrewAtDaynix Dec 20, 2020
1a30cd2
net: Added SetSteeringEBPF method for NetClientState.
AndrewAtDaynix Dec 20, 2020
ce02ac2
ebpf: Added eBPF RSS program.
AndrewAtDaynix Dec 20, 2020
a001b46
ebpf: Added eBPF RSS loader.
AndrewAtDaynix Jan 14, 2021
d3b2246
net: add ability to hide (disable) vhost_net
ybendito Jan 24, 2021
4d0508a
virtio-net: Added eBPF RSS to virtio-net.
AndrewAtDaynix Jan 14, 2021
fde4312
docs: Added eBPF documentation.
AndrewAtDaynix Jan 14, 2021
8cbb426
not for delivery: testing additions for virtio-net
ybendito Jan 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion hw/net/vhost_net.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,9 @@ VHostNetState *get_vhost_net(NetClientState *nc)

switch (nc->info->type) {
case NET_CLIENT_DRIVER_TAP:
vhost_net = tap_get_vhost_net(nc);
if (!nc->vhost_net_disabled) {
Copy link

@jasowang jasowang Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we had:

  1. vhost_net_start()/vhost_net_stop()
  2. A dedicated vhost_started variable in VirtIONet

Any reason for introducing another one at NetClientState structure?

Copy link
Author

@ybendito ybendito Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My explanation is below.

vhost_net = tap_get_vhost_net(nc);
}
break;
#ifdef CONFIG_VHOST_NET_USER
case NET_CLIENT_DRIVER_VHOST_USER:
Expand Down
1 change: 1 addition & 0 deletions include/net/net.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ struct NetClientState {
int vring_enable;
int vnet_hdr_len;
bool is_netdev;
bool vhost_net_disabled;
QTAILQ_HEAD(, NetFilterState) filters;
};

Expand Down