-
Notifications
You must be signed in to change notification settings - Fork 7
Merge 3 features #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 3 features #70
Conversation
options page seemed kind of lop-sided with this element
add margin-left to labels if they need more spacing
Changed "show debug noise", it's now a first-class citizen with a capitol 'S' just like the other checkboxes. Added "Tip:" to cursor changer option to match the other class="tip" div.
(aka: bedtime)
i may take these out of the array later
this can be done better
instead of just targets with button roles.
should <object>'s be treated differently too?
note: forEach() is unrolled here because it wasn't working for whatever reason
seeing option.enabled as a result of the blacklist was confusing to me
but we need to either reload the page or call saveOptions after clicking the browserAction button
|
I just wanted to let you know that I haven't forgotten about this, I'll hopefully get to reviewing it in the coming week. |
|
@tenerhades, does this PR contain anything that's not included in the other three? I prefer to review and merge them separately, since it's easier to review smaller code changes. |
|
No, it's just a merge of the other 3 as they were submitted in their individual pull requests. There were a couple of code conflicts, mainly in background.js, IIRC. I was just trying to save you that work with this one. Feel free to close/delete this one if you're going to review and possibly merge them individually. edit: Actually, maybe the type fixes that Typescript identified are new, but they weren't causing errors before. It was basically just some quick cleanup. |
@davidparsson, I know you're short on time. This is just a merge of the others. Namely,
This PR adds the following features and bugs
The ability to drag on links and images (and other objects) with any mouse button
The ability to temporarily disable the extension by left-clicking its icon in the extension bar. The icon changes its image to show its current state.
A right-click context menu option to add the current site to the Scrollbar Anywhere blacklist