Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct test snapshots for plot_layout_properties() #593

Merged

Conversation

markheckmann
Copy link
Contributor

@markheckmann markheckmann commented Aug 28, 2024

I missed that the test snapshots for the changes in plot_layout_properties() (commit ab4d697) were still referring to the previous function version (#592).

I now replaced the two snapshot files in tests/docs_dir/pptx-info (plot-twocontent-layout.png and plot-twocontent-layout-nolabel.png) with the new plot_layout_properties() versions.

The test should work fine now.

The test snapshots for the changes plot_layout_properties()
(commit ab4d69) were still referring to the previous version.
@davidgohel davidgohel merged commit 4c83218 into davidgohel:master Aug 28, 2024
3 checks passed
@davidgohel
Copy link
Owner

thank you

@markheckmann markheckmann deleted the issue_592_fix_test_snapshot branch August 29, 2024 12:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants