Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage to rtf #553

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Conversation

Melkiades
Copy link
Contributor

@Melkiades Melkiades commented Mar 4, 2024

Goal is > 80%, current is ~83.56%

@Melkiades
Copy link
Contributor Author

Ready for your review @davidgohel. Update on coverage (missing cov > 80%):
Screenshot 2024-03-11 194831

@Melkiades Melkiades requested a review from davidgohel March 11, 2024 18:50
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.29%. Comparing base (338ea33) to head (4513c62).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
+ Coverage   74.09%   83.29%   +9.19%     
==========================================
  Files          40       40              
  Lines        5609     5609              
==========================================
+ Hits         4156     4672     +516     
+ Misses       1453      937     -516     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@davidgohel davidgohel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the time you spent on this. Just as a small note, generally I don't bother with testing defunct functions, but it's nice to have!

@davidgohel davidgohel merged commit 5889199 into davidgohel:master Mar 12, 2024
5 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants