-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage to rtf #553
Add coverage to rtf #553
Conversation
Ready for your review @davidgohel. Update on coverage (missing cov > 80%): |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #553 +/- ##
==========================================
+ Coverage 74.09% 83.29% +9.19%
==========================================
Files 40 40
Lines 5609 5609
==========================================
+ Hits 4156 4672 +516
+ Misses 1453 937 -516 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the time you spent on this. Just as a small note, generally I don't bother with testing defunct functions, but it's nice to have!
Goal is > 80%, current is ~83.56%