Take percentage widths/heights into account #188
Conversation
When using percentages as widths or heights, the existing code returns an Integer value through parseInt (100% becomes 100), resulting in an incorrect video aspect ratio. I've added a check for the '%' character in the conditional statements, so that when percentage widths and height are used, the actual height or width of the object on the screen is measured by jQuery (using width() and height() functions).
|
The reason we use parseInt is because a percentage is not a valid value for the width property. |
|
Percentage widths and heights were allowed for Iframes in HTML 4.01 (http://www.w3.org/TR/html401/present/frames.html#h-16.5) and I've come across a few projects where they are still in use (even if they shouldn't be). I realize Iframes should not accept percentages, but all major browsers accept and render those width and height definitions. It all boils down to a matter of philosophy, I guess? |
|
A percent unit on height does nothing (It has no value to base itself upon). Width of a percentage unit does indeed expand to a percentage of it's container, although that is considered an old practice and you should instead set width and height with the style attribute. Look at Issue #116 for more info on why this is the way it is. |
When using percentages as widths or heights, the existing code returns an Integer value through parseInt (100% becomes 100), resulting in an incorrect video aspect ratio. I've added a check for the '%' character in the conditional statements, so that when percentage widths and height are used, the actual height or width of the object on the screen is measured by jQuery (using width() and height() functions).