Security and trust promise #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file should not live on this branch. Signed-off-by: Tom Daly <[email protected]>
thomasdaly5
requested review from
jacobsmith928,
joshlreese,
mksinghtx and
scotwells
joshlreese
previously approved these changes
Mar 25, 2025
Contributor
joshlreese
left a comment
joshlreese
left a comment
There was a problem hiding this comment.
Looks good! I came across a handful of typos while reviewing and recommended some fixes.
Only remaining comment is regarding line length, which I mentioned in #55 (review) as well.
mksinghtx
previously approved these changes
Mar 26, 2025
mksinghtx
left a comment
mksinghtx
left a comment
There was a problem hiding this comment.
As per our discussion on slack I have added attachments to the issues and we can take a look and reconcile and review at next iteration.
Co-authored-by: Joshua Reese <[email protected]> Signed-off-by: Tom Daly <[email protected]>
Co-authored-by: Joshua Reese <[email protected]> Signed-off-by: Tom Daly <[email protected]>
Author
Rewrapped to 80 columns as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial draft our our security and trust promise.