Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#111]: Fixes to flowershow #137

Merged
merged 3 commits into from
Aug 31, 2022
Merged

[#111]: Fixes to flowershow #137

merged 3 commits into from
Aug 31, 2022

Conversation

khalilcodes
Copy link
Contributor

Various fixes to flowershow

Tasks from #111


This PR fixes the build error from next-seo images not present in config, adds support for next links and proper svg rendering, and adds optional rendering of the github icon if the url is present in config.

Tasks

  • add check for next seo images property if present in config.js
  • add custom link component for next links
  • modify svg component to replace <p> with React.Fragment
  • add github url in config.js and optionally render in navbar

  - add checks for  next seo image in config
  - add custom anchor links component that supports next links
  - modify svg component to use react fragment replacing p tags
@netlify
Copy link

netlify bot commented Aug 31, 2022

Deploy Preview for spectacular-dragon-c1015c ready!

Name Link
🔨 Latest commit 17c678a
🔍 Latest deploy log https://app.netlify.com/sites/spectacular-dragon-c1015c/deploys/630f39937a822c00087912ef
😎 Deploy Preview https://deploy-preview-137--spectacular-dragon-c1015c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@khalilcodes khalilcodes changed the title Fixes to flowershow [#111]: Fixes to flowershow Aug 31, 2022
@rufuspollock rufuspollock merged commit 08eb7a5 into main Aug 31, 2022
@rufuspollock rufuspollock deleted the 111-flowershow-trial-fixes branch August 31, 2022 15:25
rufuspollock added a commit to rufuspollock/flowershow that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants