Skip to content

Commit

Permalink
fix: add sassOptions.outputStyle to expanded in rspack.config.js (#65)
Browse files Browse the repository at this point in the history
Coming from datavisyn/ordino#1665

### Developer Checklist (Definition of Done)

**Issue**

- [x] All acceptance criteria from the issue are met
- [ ] Tested in latest Chrome/Firefox

**UI/UX/Vis**

- [ ] Requires UI/UX/Vis review
  - [ ] Reviewer(s) are notified (_tag assignees_)
  - [ ] Review has occurred (_link to notes_)
  - [ ] Feedback is included in this PR
  - [ ] Reviewer(s) approve of concept and design

**Code**

- [x] Branch is up-to-date with the branch to be merged with, i.e.,
develop
- [x] Code is cleaned up and formatted
- [ ] Unit tests are written (frontend/backend if applicable)
- [ ] Integration tests are written (if applicable)

**PR**

- [x] Descriptive title for this pull request is provided (will be used
for release notes later)
- [x] Reviewer and assignees are defined
- [x] Add type label (e.g., *bug*, *feature*) to this pull request
- [x] Add release label (e.g., `release: minor`) to this PR following
[semver](https://semver.org/)
- [x] The PR is connected to the corresponding issue (via `Closes #...`)
- [x] [Summary of changes](#summary-of-changes) is written


### Summary of changes

- Add solution proposed by
FortAwesome/Font-Awesome#17644 (comment)


### Screenshots


### Additional notes for the reviewer(s)

-  
Thanks for creating this pull request 🤗
  • Loading branch information
puehringer authored Apr 3, 2024
2 parents 0e13597 + 392db0a commit 2d6417b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions config/rspack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,9 @@ module.exports = (webpackEnv, argv) => {
loader: 'sass-loader',
options: {
sourceMap: true, // <-- !!IMPORTANT!!
sassOptions: {
outputStyle: 'expanded', // @see https://github.com/FortAwesome/Font-Awesome/issues/17644#issuecomment-1703318326
},
},
},
],
Expand Down

0 comments on commit 2d6417b

Please sign in to comment.